The kind of cup that doesn't hold water is a "cupcake." This is a classic riddle where the answer plays on the word "cup" in cupcake, which is actually a small cake and not a real cup that holds liquid.